Skip to content

Build every Python version on tags only, wait for every build before testing - #271

Merged
xaleryb merged 1 commit into
masterfrom
ci/tests-wait-tag-matrix
Nov 20, 2026
Merged

xaleryb merged 1 commit into
masterfrom
ci/tests-wait-tag-matrix

Conversation

@jharlow-intel

Copy link
Copy Markdown
Collaborator

Two changes to intel-ci.yml and ci/matrix.py, so the workflow starts fewer runners:

  • Only a tag builds every declared Python version. A push to master now builds what a pull request builds: the oldest and the newest regular version and the newest free-threaded one. ci/matrix.py --event takes pr, tag or push, as ci/hooks.py does, and the workflow passes it the same value.
  • The test and test-wheel jobs wait for every build again. A failed build already fails the run, so no test runners start for a run that can't go green, and they stay free for other runs in the queue.

Validation: python ci/matrix.py --event pr and --event push list 3.11, 3.15 and 3.15t, and --event tag lists all seven versions, for both the conda packages and the wheels. pre-commit passes on the changed files. This pull request's own run exercises the pr path; the push and tag paths run after merge.

@jharlow-intel jharlow-intel self-assigned this Nov 20, 2026
Copilot AI balanced review requested due to automatic review settings November 20, 2026 14:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the Intel CI matrix and build-dependent test-gating changes.

No open issues 🎉

What changed in this PR

This PR reduces Intel CI runner usage by reserving full Python-version coverage for tags and skipping dependent test jobs when builds fail.

Changes:

  • Use the reduced Python matrix for pull requests and pushes; retain all declared versions for tags.
  • Standardize matrix events as pr, tag, and push.
  • Require each test job’s corresponding build matrix to succeed, and update the CI documentation.

Root AGENTS.md was unavailable, so additional repository verification was not performed.

File Description
ci/​README.md Documents tag-only full coverage and the updated event argument.
ci/​matrix.py Applies reduced matrices to pr and push and validates event choices.
.github/​workflows/​intel-ci.yml Passes normalized events and restores success-based test gating.

Review effort: Balanced

@xaleryb

xaleryb commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

The test jobs still start when a build they should wait for fails, so the "wait for every build" goal is not met yet.

  • test needs [matrix, build] (intel-ci.yml:87) and test-wheel needs [matrix, build-wheel] (intel-ci.yml:158).
  • A failed conda build leg: test is skipped, but test-wheel still starts, because it does not wait for build.
  • A failed wheel build leg: test starts, because it does not wait for build-wheel.

Expected, per the title and the description ("no test runners start for a run that can't go green"): no test job starts after any failed build.

Proposed fix: needs: [matrix, build, build-wheel] on test and needs: [matrix, build, build] on test-wheel (both build jobs on each). I checked the needs graph on 022e3ce by reading the workflow; I have not run it in Actions, so the behaviour is from the YAML. A unit test that reads the workflow and checks both needs lists is red on this head and green with the change.

Everything else I ran (ci/matrix.py for pr, push and tag, conda and wheel; pre-commit; actionlint; zizmor) is clean. Whether master pushes should keep the full matrix between tags is your call; the PR currently drops 3.12 to 3.14t there.

…testing

Pushes to master now build the versions a pull request builds: the oldest and the newest regular one and the newest free-threaded one. The test jobs start once every build has passed, so a run with a failed build starts no test runners.
@jharlow-intel
jharlow-intel force-pushed the ci/tests-wait-tag-matrix branch from 022e3ce to a55dc11 Compare November 20, 2026 20:15

@xaleryb xaleryb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked at a55dc11: the fix is the two needs lines we proposed. test and test-wheel now both need [matrix, build, build-wheel]. The needs graph gives: a failed conda build or a failed wheel build skips both test jobs, and an all-green run runs both. The matrices for pr, push and tag are unchanged from the reviewed head. The workflow parses, and the "Scan GitHub Actions workflows" check passes.

@xaleryb
xaleryb merged commit 842c285 into master Nov 20, 2026
147 of 148 checks passed
@xaleryb
xaleryb deleted the ci/tests-wait-tag-matrix branch November 20, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants